fix: prettier formatting and downgrade upload-artifact to v3 for Gitea

.gitea/workflows/ci.yaml

@@ -54,7 +54,7 @@ jobs:
               run: |
                   pipx run --spec desloppify desloppify scan --profile ci --path . --no-badge
             - name: Upload scorecard
-              uses: actions/upload-artifact@v4
+              uses: actions/upload-artifact@v3
               with:
                   name: desloppify-scorecard
                   path: scorecard.png

app/api/discord-app/[id]/route.ts

@@ -22,7 +22,9 @@ export async function GET(
     try {
         info = await getDiscordAppInfo(id);
     } catch (error) {
-        warnDev(`discord-app upstream failed: ${id} -> ${error instanceof Error ? error.message : error}`);
+        warnDev(
+            `discord-app upstream failed: ${id} -> ${error instanceof Error ? error.message : error}`,
+        );
         return jsonErrorWithCors({ error: "Upstream unavailable" }, 502, 60, origin);
     }
     if (!info) {

components/game-profile-modal.tsx

@@ -285,7 +285,9 @@ export function GameProfileModal({
                         </dl>
                     ) : null}
 
-                    {profile ? <ModalReviews profile={profile} dict={dict} localeTag={localeTag} /> : null}
+                    {profile ? (
+                        <ModalReviews profile={profile} dict={dict} localeTag={localeTag} />
+                    ) : null}
 
                     {profile?.itad && (bestPrice || historyLow) ? (
                         <ModalPrices

components/game-profile-sections.test.tsx

@@ -9,7 +9,11 @@ describe("ModalReviews", () => {
     it("renders nothing without review sources", () => {
         const dict = getDictionary("en");
         const { container } = render(
-            <ModalReviews profile={profileFixture()} dict={dict.discord.gameModal} localeTag="en-US" />,
+            <ModalReviews
+                profile={profileFixture()}
+                dict={dict.discord.gameModal}
+                localeTag="en-US"
+            />,
         );
         expect(container.textContent).toBe("");
     });

lib/api-route.ts

@@ -22,10 +22,7 @@ export function isAllowedOrigin(request: Request): boolean {
 }
 
 function resolveAllowedOrigin(origin: string | null): string {
-    if (
+    if (origin !== null && (origin === ALLOWED_ORIGIN || (isDev() && DEV_ORIGINS.has(origin)))) {
-        origin !== null &&
-        (origin === ALLOWED_ORIGIN || (isDev() && DEV_ORIGINS.has(origin)))
-    ) {
         return origin;
     }
     return ALLOWED_ORIGIN;
@@ -79,11 +76,7 @@ export function jsonErrorWithCors(
         },
     });
 }
-export function jsonWithCors(
+export function jsonWithCors(data: unknown, sMaxage = 3600, origin?: string | null): NextResponse {
-    data: unknown,
-    sMaxage = 3600,
-    origin?: string | null,
-): NextResponse {
     return NextResponse.json(data, {
         headers: {
             "Cache-Control": `public, s-maxage=${sMaxage}, stale-while-revalidate=86400`,

lib/game/game-format.ts

@@ -69,7 +69,11 @@ export function formatReleaseDate(value: string, localeTag: string): string {
     return value;
 }
 
-export function formatCount(value: number | null | undefined, localeTag: string, unit: string): string {
+export function formatCount(
+    value: number | null | undefined,
+    localeTag: string,
+    unit: string,
+): string {
     if (value == null) {
         return "—";
     }

lib/game/game-profile.test.ts

@@ -1,5 +1,10 @@
 import { describe, expect, it } from "vitest";
-import { buildLinks, mergePeople, mergePlatforms, selectScreenshots } from "@/lib/game/game-profile";
+import {
+    buildLinks,
+    mergePeople,
+    mergePlatforms,
+    selectScreenshots,
+} from "@/lib/game/game-profile";
 import type { IgdbGame } from "@/lib/game/game-profile-types";
 
 describe("mergePeople", () => {

lib/game/game-profile.ts

@@ -186,7 +186,9 @@ export function toPricePoint(p: ItadOverviewPrice["current"]): GamePricePoint |
 
 export function mapItadBlock(
     itadInfo: ItadGameInfo | null,
-    priceEntry: { current?: ItadOverviewPrice["current"]; lowest?: ItadOverviewPrice["current"] } | undefined,
+    priceEntry:
+        | { current?: ItadOverviewPrice["current"]; lowest?: ItadOverviewPrice["current"] }
+        | undefined,
 ): NonNullable<GameProfile["itad"]> | null {
     if (!process.env.ITAD_API_KEY || (!itadInfo && !priceEntry)) {
         return null;
@@ -197,10 +199,7 @@ export function mapItadBlock(
         pageUrl: itadInfo?.urls?.game ?? null,
         playerCount: itadInfo?.players?.recent ?? null,
         reviews: (itadInfo?.reviews ?? [])
-            .filter(
+            .filter((r): r is ItadReview & { source: string; url: string } => !!r.source && !!r.url)
-                (r): r is ItadReview & { source: string; url: string } =>
-                    !!r.source && !!r.url,
-            )
             .map((r) => ({
                 score: r.score ?? null,
                 source: r.source,

lib/game/lanyard.test.ts

@@ -25,9 +25,9 @@ describe("activityImageUrl", () => {
     });
 
     it("resolves Spotify keys", () => {
-        expect(activityImageUrl(activity({ assets: { large_image: "spotify:img" } }), "large")).toBe(
+        expect(
-            "https://i.scdn.co/image/img",
+            activityImageUrl(activity({ assets: { large_image: "spotify:img" } }), "large"),
-        );
+        ).toBe("https://i.scdn.co/image/img");
     });
 
     it("resolves app assets with application id", () => {